gnash-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] gnash ChangeLog backend/render_handler_agg.cpp ...


From: Udo Giacomozzi
Subject: Re: [Gnash-commit] gnash ChangeLog backend/render_handler_agg.cpp ...
Date: Tue, 6 Mar 2007 23:14:44 +0100

Hello Bastiaan,

Tuesday, March 6, 2007, 6:40:05 PM, you wrote:
BJ> -           unsigned int width = region.width()+1;

I patched this some while ago because region.width() is *not* enough!
region.width() is implemented like:

  region.width() := getMaxX() - getMinX()

In integer domain this is off by one since width==1 when
getMaxX()==getMinX() while it should be 1, otherwise it would be a
NULL region.

So, region.width()+1 *is* correct.

There must be another reason for the segfault. I think I know the
reason and will investigate this further tomorrow.

Udo





reply via email to

[Prev in Thread] Current Thread [Next in Thread]