[Gnash-commit] gnash ChangeLog server/sprite_instance.cpp test...

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  07/03/16 12:11:48

Modified files:
        .              : ChangeLog 
        server         : sprite_instance.cpp 
        testsuite/actionscript.all: MovieClip.as 
        testsuite/swfdec: PASSING 

Log message:
                * server/sprite_instance.cpp: allow overriding the _name 
property.
                * testsuite/swfdec/PASSING: more successes.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.2609&r2=1.2610
http://cvs.savannah.gnu.org/viewcvs/gnash/server/sprite_instance.cpp?cvsroot=gnash&r1=1.195&r2=1.196
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/actionscript.all/MovieClip.as?cvsroot=gnash&r1=1.36&r2=1.37
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/swfdec/PASSING?cvsroot=gnash&r1=1.4&r2=1.5

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.2609
retrieving revision 1.2610
diff -u -b -r1.2609 -r1.2610
--- ChangeLog   16 Mar 2007 10:12:57 -0000      1.2609
+++ ChangeLog   16 Mar 2007 12:11:48 -0000      1.2610
@@ -1,5 +1,9 @@
 2007-03-16 Sandro Santilli <address@hidden>
 
+       * server/sprite_instance.cpp: allow overriding the _name property.
+       * testsuite/swfdec/PASSING: more successes.
+
+2007-03-16 Sandro Santilli <address@hidden>
 
        * server/as_value.{cpp,h}: deprecate operator+=, implement valueOf
          calling.

Index: server/sprite_instance.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/sprite_instance.cpp,v
retrieving revision 1.195
retrieving revision 1.196
diff -u -b -r1.195 -r1.196
--- server/sprite_instance.cpp  15 Mar 2007 22:39:53 -0000      1.195
+++ server/sprite_instance.cpp  16 Mar 2007 12:11:48 -0000      1.196
@@ -1139,9 +1139,10 @@
        }
        else // setter
        {
-               IF_VERBOSE_ASCODING_ERRORS(
-               log_aserror("Attempt to set read-only property '_name'");
-               );
+               ptr->set_name(fn.arg(0).to_string(fn.env));
+               //IF_VERBOSE_ASCODING_ERRORS(
+               //log_aserror("Attempt to set read-only property '_name'");
+               //);
        }
 
 }
@@ -3648,7 +3649,8 @@
                // Don't push the _root name on the stack
                if ( ! parent )
                {
-                       assert(ch->get_name().empty());
+                       // it is completely legal to set root's _name
+                       //assert(ch->get_name().empty());
                        break;
                }
 

Index: testsuite/actionscript.all/MovieClip.as
===================================================================
RCS file: /sources/gnash/gnash/testsuite/actionscript.all/MovieClip.as,v
retrieving revision 1.36
retrieving revision 1.37
diff -u -b -r1.36 -r1.37
--- testsuite/actionscript.all/MovieClip.as     15 Mar 2007 22:39:54 -0000      
1.36
+++ testsuite/actionscript.all/MovieClip.as     16 Mar 2007 12:11:48 -0000      
1.37
@@ -22,7 +22,7 @@
 // compile this test case with Ming makeswf, and then
 // execute it like this gnash -1 -r 0 -v out.swf
 
-rcsid="$Id: MovieClip.as,v 1.36 2007/03/15 22:39:54 strk Exp $";
+rcsid="$Id: MovieClip.as,v 1.37 2007/03/16 12:11:48 strk Exp $";
 
 #include "check.as"
 
@@ -194,6 +194,9 @@
 #if OUTPUT_VERSION > 5
 check_equals(mc._name, "");
 check_equals(typeof(mc._name), "string");
+mc._name = "changed";
+check_equals(typeof(mc._name), "string");
+check_equals(typeof(mc), "movieclip");
 #else
 check_equals(mc._name, undefined);
 #endif

Index: testsuite/swfdec/PASSING
===================================================================
RCS file: /sources/gnash/gnash/testsuite/swfdec/PASSING,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -b -r1.4 -r1.5
--- testsuite/swfdec/PASSING    15 Mar 2007 22:39:54 -0000      1.4
+++ testsuite/swfdec/PASSING    16 Mar 2007 12:11:48 -0000      1.5
@@ -38,3 +38,5 @@
 and-or-6.swf
 and-or-7.swf
 transform.swf
+name.swf
+name2.swf