[Gnash-commit] gnash ChangeLog testsuite/MovieTester.h testsui... [release-0-8-0]

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Branch:         release-0-8-0
Changes by:     Sandro Santilli <strk>  07/06/07 12:35:09

Modified files:
        .              : ChangeLog 
        testsuite      : MovieTester.h 
        testsuite/misc-ming.all: Video-EmbedSquareTestRunner.cpp 

Log message:
                * testsuite/MovieTester.h: add a canTestRendering() method.
                * testsuite/misc-ming.all/Video-EmbedSquareTestRunner.cpp:
                  Don't run the pixel checking part if MovieTester can't test
                  rendering. Raise an UNTESTED label instead, so it's reported.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&only_with_tag=release-0-8-0&r1=1.3451.2.29&r2=1.3451.2.30
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/MovieTester.h?cvsroot=gnash&only_with_tag=release-0-8-0&r1=1.23.4.1&r2=1.23.4.2
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/misc-ming.all/Video-EmbedSquareTestRunner.cpp?cvsroot=gnash&only_with_tag=release-0-8-0&r1=1.2.4.1&r2=1.2.4.2

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.3451.2.29
retrieving revision 1.3451.2.30
diff -u -b -r1.3451.2.29 -r1.3451.2.30
--- ChangeLog   7 Jun 2007 12:12:34 -0000       1.3451.2.29
+++ ChangeLog   7 Jun 2007 12:35:07 -0000       1.3451.2.30
@@ -1,3 +1,10 @@
+2007-06-06 Sandro Santilli <address@hidden>
+
+       * testsuite/MovieTester.h: add a canTestRendering() method.
+       * testsuite/misc-ming.all/Video-EmbedSquareTestRunner.cpp: 
+         Don't run the pixel checking part if MovieTester can't test
+         rendering. Raise an UNTESTED label instead, so it's reported.
+
 2007-06-07 Tomas Groth Christensen <address@hidden>
 
        * backend/sound_handler.cpp: Fixed a warning.

Index: testsuite/MovieTester.h
===================================================================
RCS file: /sources/gnash/gnash/testsuite/MovieTester.h,v
retrieving revision 1.23.4.1
retrieving revision 1.23.4.2
diff -u -b -r1.23.4.1 -r1.23.4.2
--- testsuite/MovieTester.h     6 Jun 2007 13:33:16 -0000       1.23.4.1
+++ testsuite/MovieTester.h     7 Jun 2007 12:35:09 -0000       1.23.4.2
@@ -228,6 +228,14 @@
        ///
        bool canTestSound() const { return _sound_handler.get() != NULL; }
 
+       /// Return true if this build of MovieTester supports pixel checking 
+       //
+       /// Pixel checking will be supported as long as a testing-capable 
render handler
+       /// was compiled in. Testing-capable means capable of off-screen 
rendering, which
+       /// is implementing the render_handler::initTestBuffer method.
+       ///
+       bool canTestRendering() const { return ! _testingRenderers.empty(); }
+
 private:
 
        /// Initialize testing renderers

Index: testsuite/misc-ming.all/Video-EmbedSquareTestRunner.cpp
===================================================================
RCS file: 
/sources/gnash/gnash/testsuite/misc-ming.all/Video-EmbedSquareTestRunner.cpp,v
retrieving revision 1.2.4.1
retrieving revision 1.2.4.2
diff -u -b -r1.2.4.1 -r1.2.4.2
--- testsuite/misc-ming.all/Video-EmbedSquareTestRunner.cpp     5 Jun 2007 
14:45:43 -0000       1.2.4.1
+++ testsuite/misc-ming.all/Video-EmbedSquareTestRunner.cpp     7 Jun 2007 
12:35:09 -0000       1.2.4.2
@@ -46,6 +46,12 @@
        sprite_instance* root = tester.getRootMovie();
        assert(root);
 
+       if ( ! tester.canTestRendering() )
+       {
+               cout << "UNTESTED: rendering can't be tested with this build." 
<< endl;
+               return EXIT_SUCCESS; // so testing doesn't abort
+       } 
+
        rgba red(255,0,0,255);
        rgba yellow(255,255,0,255);