[Gnash-commit] gnash ChangeLog server/namedStrings.h server/na...

[Chad Musick]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Chad Musick <cmusick>   07/09/23 22:33:57

Modified files:
        .              : ChangeLog 
        server         : namedStrings.h namedStrings.cpp 

Log message:
        More documentation, avoid multiple keys for one string literal.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.4382&r2=1.4383
http://cvs.savannah.gnu.org/viewcvs/gnash/server/namedStrings.h?cvsroot=gnash&r1=1.2&r2=1.3
http://cvs.savannah.gnu.org/viewcvs/gnash/server/namedStrings.cpp?cvsroot=gnash&r1=1.1&r2=1.2

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.4382
retrieving revision 1.4383
diff -u -b -r1.4382 -r1.4383
--- ChangeLog   23 Sep 2007 22:09:14 -0000      1.4382
+++ ChangeLog   23 Sep 2007 22:33:56 -0000      1.4383
@@ -1,5 +1,11 @@
 2007-09-24 Chad Musick <address@hidden>
 
+       * server/namedStrings.h: More documentation,
+         remove duplicate enumeration
+       * server/namedStrings.cpp: Don't duplicate string "Stage".
+
+2007-09-24 Chad Musick <address@hidden>
+
        * configure.ac: Add requirement of boost serialization library
        * macros/boost.m4: Add requirement of boost serialization library
 

Index: server/namedStrings.h
===================================================================
RCS file: /sources/gnash/gnash/server/namedStrings.h,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -b -r1.2 -r1.3
--- server/namedStrings.h       23 Sep 2007 09:07:29 -0000      1.2
+++ server/namedStrings.h       23 Sep 2007 22:33:56 -0000      1.3
@@ -26,7 +26,21 @@
 
 /// Named String Values
 //
-/// Long description here...
+/// These are enumerations of the strings which should have known string
+/// table values.  They are the first strings added to the string table,
+/// and the key will be equal to the enumeration.
+///
+/// Lowercase letters in the enum value signal the format of the string
+/// literals associated with these enums.
+/// i: Initial capital for groups which are normally initial lower case.
+/// For example: PROP_iSTAGE is "Stage";
+/// u: An underscore
+/// For example: PROP_uuPROTOuu is "__proto__"
+/// _: The next letter is capitalized
+/// For example: PROP_ON_LOAD is "onLoad"
+///
+/// Names beginning with PROP_ have a lowercase initial letter
+/// Names beginning with CLASS_ have an uppercase initial letter
 ///
 namespace NSV {
 
@@ -97,7 +111,7 @@
                PROP_uYMOUSE,
                PROP_uYSCALE,
                CLASS_SYSTEM,
-               CLASS_STAGE,
+               CLASS_STAGE = PROP_iSTAGE,
                CLASS_MOVIE_CLIP,
                CLASS_TEXT_FIELD,
                CLASS_MATH,

Index: server/namedStrings.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/namedStrings.cpp,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -b -r1.1 -r1.2
--- server/namedStrings.cpp     23 Sep 2007 08:48:18 -0000      1.1
+++ server/namedStrings.cpp     23 Sep 2007 22:33:56 -0000      1.2
@@ -93,7 +93,7 @@
        { "_ymouse", NSV::PROP_uYMOUSE },
        { "_yscale", NSV::PROP_uYSCALE },
        { "System", NSV::CLASS_SYSTEM },
-       { "Stage", NSV::CLASS_STAGE },
+//     { "Stage", NSV::CLASS_STAGE }, // Identical to PROP_iSTAGE
        { "MovieClip", NSV::CLASS_MOVIE_CLIP },
        { "TextField", NSV::CLASS_TEXT_FIELD },
        { "Math", NSV::CLASS_MATH },