Re: [Gnash-commit] gnash ChangeLog gui/gtk.cpp gui/gtksup.h

[Bastiaan Jacques]

On Thu, 27 Sep 2007, strk wrote:

> On Thu, Sep 27, 2007 at 07:26:04PM +0000, Bastiaan Jacques wrote:
>
> > +    /// Add a listener with default priority that listens for IN and HUP
> > +    /// events on a file descriptor.
> > +    //
> > +    /// @param fd The file descriptor to poll.
> > +    /// @param callback A pointer to a callback function with the following
> > +    ///                 signature:
> > +    ///        bool func(void*, int, void* data)
> > +    ///        The first and second arguments should be ignored.
> > +    ///        The last argument is a user-specified pointer. The
> > +    ///        callback should return false if the listener is to be removed.
> > +    /// @param data A pointer to a user-defined data structure.
> > +    /// @return true on success, false on failure.
> > +    bool addFDListener(int fd, callback_t callback, void* data);
>
> The first and second arguments should be ignored ??

Yes. Since the first two arguments are data types from Glib, it is probably
undesirable to use them in GUI-neutral code. When we have a generic interface
in the GUI (base) class, we can do better. For now, though, this should get
the job done.

Bastiaan