Re: [Gnash-commit] gnash/testsuite/misc-swfc.all opcode_guard_test...

[zou lunkai]

> +      // Note, there's no soft reference for dup1, but I bet sprite 'dup1'
> +      // still leaks in Gnash due to hard reference as_environment::m_target.

ops, should be no problem is setTarget('mc') and setTarget('')  works together.

On 9/30/07, Zou Lunkai <address@hidden> wrote:
> CVSROOT:        /sources/gnash
> Module name:    gnash
> Changes by:     Zou Lunkai <zoulunkai>  07/09/30 05:48:33
>
> Modified files:
>         testsuite/misc-swfc.all: opcode_guard_test2.sc
>
> Log message:
>         add comments
>
> CVSWeb URLs:
> http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/misc-swfc.all/opcode_guard_test2.sc?cvsroot=gnash&r1=1.2&r2=1.3
>
> Patches:
> Index: opcode_guard_test2.sc
> ===================================================================
> RCS file: /sources/gnash/gnash/testsuite/misc-swfc.all/opcode_guard_test2.sc,v
> retrieving revision 1.2
> retrieving revision 1.3
> diff -u -b -r1.2 -r1.3
> --- opcode_guard_test2.sc       29 Sep 2007 06:33:25 -0000      1.2
> +++ opcode_guard_test2.sc       30 Sep 2007 05:48:32 -0000      1.3
> @@ -62,7 +62,12 @@
>      dup1.testVar = 'dup1_var';
>      setTarget('dup1');
>        removeMovieClip(_root.dup1);
> -      // seems Gnash discarded the follow 2 tests
> +      // seems Gnash discarded the following 2 tests, caused by opcode guard 
> with
> +      // current target.  I think we should use the original target.
> +      // Note, there's no soft reference for dup1, but I bet sprite 'dup1'
> +      // still leaks in Gnash due to hard reference as_environment::m_target.
> +      // I guess sprites(and maybe all referencable characters) should be 
> referenced by
> +      // _target(string) value, otherwise too much leaks to afford.
>        _root.check_equals(typeof(_root.dup1), 'undefined');
>        _root.check_equals(testVar, undefined);
>      setTarget('');
> @@ -70,7 +75,7 @@
>      dup2.testVar = 'dup2_var';
>      with('dup2'){
>        removeMovieClip(_root.dup2);
> -      // seems Gnash discarded the follow 2 tests
> +      // seems Gnash discarded the following 2 tests
>        _root.check_equals(typeof(_root.dup2), 'undefined');
>        _root.check_equals(testVar, undefined);
>      }
>
>
> _______________________________________________
> Gnash-commit mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/gnash-commit
>