Re: [Gnash-commit] gnash ChangeLog testsuite/actionscript.all/Movi...

[Sandro Santilli]

On Thu, Oct 04, 2007 at 07:23:56PM +0800, zou lunkai wrote:
> > IMPORTANT NOTE:
> > We need a test for opcode guarding to check if Unloaded and Removed
> > makes a difference there. If the removed character has an onUnload event
> > handler, is the remaining of actions after it's removal from stage still
> > discarded ?
> >
> I think the answer is yes.  It was tested in
> "testsuite/misc-swfc.all/movieclip_destruction_test1.sc"
> 
> There are related comments and code block(in movieclip_destruction_test1.sc):
> 
> // No matter onUnload defined or not, the above actions still got skipped.
> //#define DEFINE_ONUNLOAD
> #ifdef DEFINE_ONUNLOAD
>   .action:
>     // Define onUnload(for deduction)
>      mc1.onUnload = function () {};
>   .end
> #endif
> 
> It was a quick test but disabled for some reason(maybe for testing
> some other cases).   I can add some focused tests when I am back.

I'd still like to find a good way to test wheter actions are really aborted or 
not.
What about running an infinite loop ?
If actions are discarded there'll be no visible effect, otherwise
the "scripts are making the movie slow" popup should come out.
This is important to avoid confusion between names resolution not working
and actual VM not executing opcodes.

--strk;