gnash-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] gnash ChangeLog libbase/URL.h server/sprite_ins...


From: strk
Subject: Re: [Gnash-commit] gnash ChangeLog libbase/URL.h server/sprite_ins...
Date: Sat, 12 Jan 2008 21:06:37 +0100

On Sat, Jan 12, 2008 at 12:48:07PM +0000, Udo Giacomozzi wrote:

> +     /// Set the 'querystring' member of this URL to a new value
> +  ///
> +  void set_querystring(std::string value) { _querystring = value; } 

Take a const std::string& value there, or the value would be copied
twice (once to pass as parameter, once to copy to _queristring).

Also, should you check for _querystring being non-empty ?
I mean, you may want to *append* values, not necessarely 
destroy any older one.

--strk;




reply via email to

[Prev in Thread] Current Thread [Next in Thread]