[Gnash-commit] gnash ChangeLog server/as_object.cpp

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  08/02/04 11:32:26

Modified files:
        .              : ChangeLog 
        server         : as_object.cpp 

Log message:
        remove useless round trip (key->name->key) in getOwnProperty

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.5553&r2=1.5554
http://cvs.savannah.gnu.org/viewcvs/gnash/server/as_object.cpp?cvsroot=gnash&r1=1.96&r2=1.97

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.5553
retrieving revision 1.5554
diff -u -b -r1.5553 -r1.5554
--- ChangeLog   4 Feb 2008 09:47:49 -0000       1.5553
+++ ChangeLog   4 Feb 2008 11:32:25 -0000       1.5554
@@ -1,5 +1,7 @@
 2008-02-04 Sandro Santilli <address@hidden>
 
+       * server/as_object.cpp (getOwnProperty): remove useless round
+         trip (key->name->key).
        * server/as_object.cpp (setPropFlags): fix handling of second
          argument (null, array or invalid).
        * testsuite/actionscript.all/Global.as: add more tests for

Index: server/as_object.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/as_object.cpp,v
retrieving revision 1.96
retrieving revision 1.97
diff -u -b -r1.96 -r1.97
--- server/as_object.cpp        4 Feb 2008 09:47:50 -0000       1.96
+++ server/as_object.cpp        4 Feb 2008 11:32:26 -0000       1.97
@@ -789,13 +789,7 @@
 Property*
 as_object::getOwnProperty(string_table::key key, string_table::key nsname)
 {
-       // TODO:
-       // Removing this absurd round-trip from key to name to key
-       // breaks toString_valueOf (why? fix me!!)
-       //
-       string_table& st = _vm.getStringTable();
-               std::string name = st.value(key);
-       return _members.getProperty(st.find(PROPNAME(name)), nsname);
+       return _members.getProperty(key, nsname);
 }
 
 as_value