Re: [Gnash-commit] gnash libmedia/Makefile.am libmedia/VideoDecode...

[strk]

On Sat, Feb 23, 2008 at 06:12:53PM +0000, Bastiaan Jacques wrote:

> +/// \brief Abstract base class for embedded video decoders.

Surely NOT for 0.8.2, but does it make sense to have a different
class for embedded and external video decoders ?

> +/// This class represents a video frame that has not yet been decoded.
> +class EncodedVideoFrame : public boost::noncopyable
> +{
> +public:
> +  /// @param buffer Pointer to the video data corresponding to this frame. 
> This
> +  ///               class takes ownership of the pointer.
> +  /// @param buf_size The size, in bytes, of the data pointed to in the 
> buffer
> +  ///                 argument
> +  /// @param frame_number The number of the frame in the video stream.
> +  EncodedVideoFrame(boost::uint8_t* buffer, size_t buf_size, size_t 
> frame_num)
> +    : _buffer(buffer),
> +      _buffer_size(buf_size),
> +      _frame_number(frame_num)
> +  {}

Where is format (encoding) of the frame stored ?
There's no interface on the embedded video decoder nor in the
EncodedVideoFrame.
Documenting the intended use would be enough for now, as it'll
help refining the design.

--strk;