[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Gnash-commit] gnash ChangeLog server/asobj/string.cpp
From: |
Benjamin Wolsey |
Subject: |
[Gnash-commit] gnash ChangeLog server/asobj/string.cpp |
Date: |
Fri, 28 Mar 2008 12:24:05 +0000 |
CVSROOT: /sources/gnash
Module name: gnash
Changes by: Benjamin Wolsey <bwy> 08/03/28 12:24:05
Modified files:
. : ChangeLog
server/asobj : string.cpp
Log message:
* server/asobj/string.cpp: (charAt) prevent another potential
out-of-bounds string access.
CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.6056&r2=1.6057
http://cvs.savannah.gnu.org/viewcvs/gnash/server/asobj/string.cpp?cvsroot=gnash&r1=1.62&r2=1.63
Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.6056
retrieving revision 1.6057
diff -u -b -r1.6056 -r1.6057
--- ChangeLog 28 Mar 2008 12:22:44 -0000 1.6056
+++ ChangeLog 28 Mar 2008 12:24:04 -0000 1.6057
@@ -1,5 +1,10 @@
2008-03-28 Benjamin Wolsey <address@hidden>
+ * server/asobj/string.cpp: (charAt) prevent another potential
+ out-of-bounds string access.
+
+2008-03-28 Benjamin Wolsey <address@hidden>
+
* libbase/gmemory.h: add DSOEXPORT to allow the testsuite to
build with visibility support enabled.
* libamf/lcshm.h: make Listener class visible (testsuite).
Index: server/asobj/string.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/asobj/string.cpp,v
retrieving revision 1.62
retrieving revision 1.63
diff -u -b -r1.62 -r1.63
--- server/asobj/string.cpp 28 Mar 2008 11:23:27 -0000 1.62
+++ server/asobj/string.cpp 28 Mar 2008 12:24:04 -0000 1.63
@@ -590,7 +590,7 @@
size_t index = static_cast<size_t>(fn.arg(0).to_number());
- if (index >= wstr.size()) {
+ if (index >= wstr.length()) {
as_value rv;
rv.set_nan();
return rv;
@@ -610,9 +610,9 @@
ENSURE_FN_ARGS(1, 1, "");
- size_t index = fn.arg(0).to_number<size_t>();
+ size_t index = static_cast<size_t>(fn.arg(0).to_number());
- if (index > wstr.size()) {
+ if (index >= wstr.length()) {
as_value rv;
rv.set_nan();
return rv;