[Gnash-commit] gnash ChangeLog server/asobj/Number.cpp testsui...

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  08/04/02 09:39:59

Modified files:
        .              : ChangeLog 
        server/asobj   : Number.cpp 
        testsuite/actionscript.all: Boolean.as 

Log message:
        * server/asobj/Number.as (toString_method): Number.prototype.toString
          is supposed to work _only_ for the number object.
        * testsuite/actionscript.all/Boolean.as: !"true" succeeds.
        * testsuite/swfdec/PASSING: number.swf succeeds.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.6158&r2=1.6159
http://cvs.savannah.gnu.org/viewcvs/gnash/server/asobj/Number.cpp?cvsroot=gnash&r1=1.41&r2=1.42
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/actionscript.all/Boolean.as?cvsroot=gnash&r1=1.20&r2=1.21

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.6158
retrieving revision 1.6159
diff -u -b -r1.6158 -r1.6159
--- ChangeLog   2 Apr 2008 08:53:44 -0000       1.6158
+++ ChangeLog   2 Apr 2008 09:39:58 -0000       1.6159
@@ -1,3 +1,10 @@
+2008-04-01 Sandro Santilli <address@hidden>
+
+       * server/asobj/Number.as (toString_method): Number.prototype.toString
+         is supposed to work _only_ for the number object.
+       * testsuite/actionscript.all/Boolean.as: !"true" succeeds.
+       * testsuite/swfdec/PASSING: number.swf succeeds.
+
 2008-04-01 Benjamin Wolsey <address@hidden>
 
        * server/as_value.cpp: use stringstream instead of strtod to avoid

Index: server/asobj/Number.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/asobj/Number.cpp,v
retrieving revision 1.41
retrieving revision 1.42
diff -u -b -r1.41 -r1.42
--- server/asobj/Number.cpp     31 Mar 2008 23:18:34 -0000      1.41
+++ server/asobj/Number.cpp     2 Apr 2008 09:39:59 -0000       1.42
@@ -197,7 +197,9 @@
 as_value
 number_as_object::toString_method(const fn_call& fn)
 {
-       boost::intrusive_ptr<as_object> obj = fn.this_ptr;
+       // Number.toString must only work for number object, not generic ones.
+       // This is so trace(Number.prototype) doesn't return 0 ...
+       boost::intrusive_ptr<number_as_object> obj = 
ensureType<number_as_object>(fn.this_ptr);
 
        double val = obj->get_numeric_value();
        unsigned radix=10;

Index: testsuite/actionscript.all/Boolean.as
===================================================================
RCS file: /sources/gnash/gnash/testsuite/actionscript.all/Boolean.as,v
retrieving revision 1.20
retrieving revision 1.21
diff -u -b -r1.20 -r1.21
--- testsuite/actionscript.all/Boolean.as       11 Mar 2008 19:31:46 -0000      
1.20
+++ testsuite/actionscript.all/Boolean.as       2 Apr 2008 09:39:59 -0000       
1.21
@@ -21,7 +21,7 @@
 // execute it like this gnash -1 -r 0 -v out.swf
 
 
-rcsid="$Id: Boolean.as,v 1.20 2008/03/11 19:31:46 strk Exp $";
+rcsid="$Id: Boolean.as,v 1.21 2008/04/02 09:39:59 strk Exp $";
 #include "check.as"
 
 check_equals(typeof(Boolean), 'function');
@@ -78,7 +78,7 @@
 check( "1" );
 #if OUTPUT_VERSION < 7
  check( ! "0" );
- xcheck( ! "true" );
+ check( ! "true" );
  check( ! "false" );
 #else
  check( "0" );