[Gnash-commit] gnash ChangeLog testsuite/actionscript.all/Obje...

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  08/04/03 10:34:50

Modified files:
        .              : ChangeLog 
        testsuite/actionscript.all: Object.as 

Log message:
        test that null is a valid setter argument for setProperty (gnash fails).

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.6167&r2=1.6168
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/actionscript.all/Object.as?cvsroot=gnash&r1=1.51&r2=1.52

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.6167
retrieving revision 1.6168
diff -u -b -r1.6167 -r1.6168
--- ChangeLog   3 Apr 2008 09:43:15 -0000       1.6167
+++ ChangeLog   3 Apr 2008 10:34:49 -0000       1.6168
@@ -1,5 +1,10 @@
 2008-04-03 Sandro Santilli <address@hidden>
 
+       * testsuite/actionscript.all/Object.as: test that null is a valid
+         setter argument for setProperty (gnash fails).
+
+2008-04-03 Sandro Santilli <address@hidden>
+
        * server/parser/sprite_definition.cpp (read): warn only once about
          less SHOWFRAME then advertised in header.
        * testsuite/misc-ming.all/DefineEditTextVariableNameText.c:

Index: testsuite/actionscript.all/Object.as
===================================================================
RCS file: /sources/gnash/gnash/testsuite/actionscript.all/Object.as,v
retrieving revision 1.51
retrieving revision 1.52
diff -u -b -r1.51 -r1.52
--- testsuite/actionscript.all/Object.as        1 Apr 2008 09:31:07 -0000       
1.51
+++ testsuite/actionscript.all/Object.as        3 Apr 2008 10:34:50 -0000       
1.52
@@ -21,7 +21,7 @@
 // execute it like this gnash -1 -r 0 -v out.swf
 
 
-rcsid="$Id: Object.as,v 1.51 2008/04/01 09:31:07 zoulunkai Exp $";
+rcsid="$Id: Object.as,v 1.52 2008/04/03 10:34:50 strk Exp $";
 #include "check.as"
 
 // Test things in Class Object (swf5~swf8)
@@ -405,6 +405,30 @@
 check_equals(o1.mem1, 6);
 check_equals(o2.mem2, 6);
 
+// Test having a getter but not a setter
+getter = function() { _root.getcalls++; };
+o = {};
+r = o.addProperty('lmissing', getter);
+check(!r);
+r = o.addProperty('lundef', getter, undefined);
+check(!r);
+r = o.addProperty('lnull', getter, o); // self as setter..
+check(!r);
+r = o.addProperty('lnull', getter, null);
+xcheck(r);
+getcalls=0;
+t=o.lnull;
+xcheck_equals(getcalls, 1);
+
+// Test having a setter but not a getter (invalid)
+setter = function() { _root.setcalls++; };
+o = {};
+r = o.addProperty('lmissing', undefined, setter);
+check(!r);
+r = o.addProperty('lundef', null, setter);
+check(!r);
+
+
 // Object.addProperty wasn't in SWF5
 #endif // OUTPUT_VERSION > 5
 
@@ -578,6 +602,6 @@
 #endif
 
 #if OUTPUT_VERSION >= 6
-totals(180);
+totals(187);
 #endif