[Gnash-commit] gnash ChangeLog server/asobj/System.h server/as...

[Benjamin Wolsey]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Benjamin Wolsey <bwy>   08/04/15 07:52:44

Modified files:
        .              : ChangeLog 
        server/asobj   : System.h System.cpp 

Log message:
                * server/asobj/System.{h,cpp}: System is not a proper class,
                  so doesn't need a constructor.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.6274&r2=1.6275
http://cvs.savannah.gnu.org/viewcvs/gnash/server/asobj/System.h?cvsroot=gnash&r1=1.13&r2=1.14
http://cvs.savannah.gnu.org/viewcvs/gnash/server/asobj/System.cpp?cvsroot=gnash&r1=1.29&r2=1.30

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.6274
retrieving revision 1.6275
diff -u -b -r1.6274 -r1.6275
--- ChangeLog   15 Apr 2008 07:51:19 -0000      1.6274
+++ ChangeLog   15 Apr 2008 07:52:43 -0000      1.6275
@@ -1,5 +1,10 @@
 2008-04-15 Benjamin Wolsey <address@hidden>
        
+       * server/asobj/System.{h,cpp}: System is not a proper class,
+         so doesn't need a constructor.
+
+2008-04-15 Benjamin Wolsey <address@hidden>
+       
        * testsuite/actionscript.all/Math.as: tests for Math class
          instantiation (not a proper class).
        * testsuite/actionscript.all/System.as: tests for System

Index: server/asobj/System.h
===================================================================
RCS file: /sources/gnash/gnash/server/asobj/System.h,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -b -r1.13 -r1.14
--- server/asobj/System.h       26 Mar 2008 21:34:23 -0000      1.13
+++ server/asobj/System.h       15 Apr 2008 07:52:43 -0000      1.14
@@ -23,11 +23,7 @@
 
 namespace gnash {
   
-class system_as_object : public as_object
-{
-public:
-       system_as_object();
-};
+// System isn't a proper class, so doesn't need a constructor.
 
 void system_class_init(as_object& global);
 

Index: server/asobj/System.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/asobj/System.cpp,v
retrieving revision 1.29
retrieving revision 1.30
diff -u -b -r1.29 -r1.30
--- server/asobj/System.cpp     14 Apr 2008 14:16:39 -0000      1.29
+++ server/asobj/System.cpp     15 Apr 2008 07:52:43 -0000      1.30
@@ -209,9 +209,9 @@
        static boost::intrusive_ptr<as_object> proto;
        if ( proto == NULL )
        {
-               int flags  = as_prop_flags::dontDelete;
-                   flags |= as_prop_flags::dontEnum;
-                   flags |= as_prop_flags::readOnly;
+               const int flags = as_prop_flags::dontDelete
+                               | as_prop_flags::dontEnum
+                               | as_prop_flags::readOnly;
 
                proto = new as_object(getObjectInterface());
 
@@ -270,23 +270,6 @@
        proto.init_property("useCodepage", *gettersetter, *gettersetter);
 }
 
-static as_object*
-getSystemInterface()
-{
-       static boost::intrusive_ptr<as_object> proto;
-       if ( proto == NULL )
-       {
-               proto = new as_object(getObjectInterface());
-               attachSystemInterface(*proto);
-       }
-       return proto.get();
-}
-
-system_as_object::system_as_object()
-       :
-       as_object(getSystemInterface()) // pass System inheritence
-{
-}
 
 as_value
 system_security_allowdomain(const fn_call& /*fn*/)
@@ -295,6 +278,7 @@
     return as_value();
 }
 
+
 as_value
 system_security_allowinsecuredomain(const fn_call& /*fn*/)
 {
@@ -302,6 +286,7 @@
     return as_value();
 }
 
+
 as_value
 system_security_loadpolicyfile(const fn_call& /*fn*/)
 {
@@ -309,6 +294,7 @@
     return as_value();
 }
 
+
 as_value
 system_setclipboard(const fn_call& /*fn*/)
 {
@@ -316,6 +302,7 @@
     return as_value();
 }
 
+
 as_value
 system_showsettings(const fn_call& /*fn*/)
 {
@@ -323,6 +310,7 @@
     return as_value();
 }
 
+
 // FIXME: should return true if shared object files
 // are stored under an exact domain name (www.gnashdev.org or
 // gnashdev.org); false if both are stored under gnashdev.org.
@@ -347,6 +335,7 @@
     }
 }
 
+
 // FIXME: if true, SWF6+ should treat characters as Latin
 // charset variants. If false (default), as UTF-8.
 // Can be set.
@@ -370,6 +359,7 @@
     }
 }
 
+
 void
 system_class_init(as_object& global)
 {
@@ -380,6 +370,7 @@
        global.init_member("System", obj.get());
 }
 
+
 const std::string&
 systemLanguage()
 {