Re: [Gnash-commit] gnash ChangeLog server/button_character_instanc...

[Sandro Santilli]

On Mon, Apr 14, 2008 at 01:04:22AM +0200, Udo Giacomozzi wrote:
> Hello Sandro,
> 
> Friday, April 11, 2008, 8:30:47 PM, you wrote:
> SS>         // see if the two lists differ and restart characters if needed
> SS> +       // TODO: FIXME: this is not how you check for equality :/
> SS>         if (new_list.size() != old_list.size())
> SS>                 set_invalidated();              // something changed 
> 
> 
> Agree, this doesn't look right.

Note that I tried just calling set_invalidated no matter what, and didn't help.

> SS> +  // NOTE: we do have that method now, it's called 
> get_active_characters(state)
> 
> Then it would be better to rewrite that piece of code, wouldn't it?

Scary, using the new method makes things worst...

> So this is a false patch and you better revert your commit.

Ok, reverted.

> I guess that "something changed" code above (where you added the TODO)
> is the real culprit and correcting that expression will probably
> really fix the bug.
> 
> Please try that for me, I can't check it myself until 2-3 days.

Tried what I mentioned before (always callign set_invalidated).
Didn't work. 

--strk;