Re: [Gnash-commit] gnash ChangeLog gui/Makefile.am gui/Player.cpp ...

[strk]

On Fri, May 02, 2008 at 08:23:33PM +0000, Russ Nelson wrote:

> Log message:
>       * incorporate the rest of Craig Kelley's "dump" gui code.

> http://cvs.savannah.gnu.org/viewcvs/gnash/libmedia/ffmpeg/sound_handler_sdl.cpp?cvsroot=gnash&r1=1.3&r2=1.4


> +SDL_sound_handler::SDL_sound_handler()
> +{
> +    SDL_sound_handler(NULL);
>  }

The above doesn't make sense.
It will create a temporary SDL_sound_handler object and then discard it,
will NOT initialize any member.
Moreover, SDL_sound_handler overridden ctor takes a string now.

--strk;