Re: [Gnash-commit] gnash ChangeLog server/asobj/NetStreamFfmpeg.cp...

[Sandro Santilli]

On Fri, May 09, 2008 at 06:43:35PM +0200, Bastiaan Jacques wrote:
> 
> 
> On Fri, 9 May 2008, Sandro Santilli wrote:
> 
> >Index: server/asobj/NetStreamFfmpeg.cpp
> >===================================================================
> >RCS file: /sources/gnash/gnash/server/asobj/NetStreamFfmpeg.cpp,v
> >retrieving revision 1.114
> >retrieving revision 1.115
> >diff -u -b -r1.114 -r1.115
> >--- server/asobj/NetStreamFfmpeg.cpp 9 May 2008 07:27:14 -0000       1.114
> >+++ server/asobj/NetStreamFfmpeg.cpp 9 May 2008 10:03:25 -0000       1.115
> >@@ -77,7 +77,9 @@
> >     m_last_audio_timestamp(0),
> >     m_current_timestamp(0),
> >     m_unqueued_data(NULL),
> >-    m_time_of_pause(0)
> >+    m_time_of_pause(0),
> >+
> >+    _decoderBuffer(0)
> 
> Nit: I prefer NULL to 0.

http://jcatki.no-ip.org:8080/fncpp/NullOrZero

> >NetStreamFfmpeg::~NetStreamFfmpeg()
> >{
> >+    if ( _decoderBuffer ) delete [] _decoderBuffer;
> 
> delete will do the NULL check for you.
> 
> >-    unsigned int bufsize = (AVCODEC_MAX_AUDIO_FRAME_SIZE * 3) / 2;
> >+    //static const unsigned int bufsize = (AVCODEC_MAX_AUDIO_FRAME_SIZE 
> >* 3) / 2;
> >+    static const unsigned int bufsize = AVCODEC_MAX_AUDIO_FRAME_SIZE;
> 
> I would guess this was intended to provide aligned malloc.

malloc is always aligned, doesn't depend on size, or what am I missing ?

--strk;