Re: [Gnash-commit] gnash ChangeLog libbase/FLVParser.cpp

[Sandro Santilli]

On Fri, May 09, 2008 at 06:46:29PM +0200, Bastiaan Jacques wrote:
> 
> 
> On Fri, 9 May 2008, Sandro Santilli wrote:
> 
> >CVSROOT:     /sources/gnash
> >Module name: gnash
> >Changes by:  Sandro Santilli <strk>  08/05/09 11:12:05
> >
> >Modified files:
> >     .              : ChangeLog
> >     libbase        : FLVParser.cpp
> >
> >Log message:
> >             * libbase/FLVParser.cpp: use 64 (rather then 8) padding 
> >             bytes.
> >               I've no idea what that padding means and why is needed, 
> >               anyway
> >               it fixes an illegal read of 33 bytes past the allocated set
> >               watching http://www.youtube.com/watch?v=P48VFXltFyM.
> 
> Some of ffmpeg's decoders use stream readers that will go past the end
> of the buffer you pass it (by design) because they read 64 bytes at a
> time. So we increase the buffer size to make sure they don't crash.
> (This is recommended by the ffmpeg docs.)

Then rather then adding a fixed number (was 8, now is 64) we should
really add as much as to make the size a multiple of 64, right ?

--strk;