gnash-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] gnash ChangeLog libamf/amf.cpp libamf/amf.h lib...


From: strk
Subject: Re: [Gnash-commit] gnash ChangeLog libamf/amf.cpp libamf/amf.h lib...
Date: Fri, 16 May 2008 09:07:57 +0200

On Fri, May 16, 2008 at 03:46:40AM +0000, Rob Savoye wrote:

> -#ifndef GNASH_TRUST_AMF
> -          ENSUREBYTES(tmpptr, tooFar, sizeof(boost::uint16_t)); 
> -#endif
> -       length = *reinterpret_cast<boost::uint16_t *>(tmpptr);

What was wrong in checking input boundaries before reading ?
We'd be back to memory corruption instead of exception throwing
in the malformed-or-tought-so case...

--strk;




reply via email to

[Prev in Thread] Current Thread [Next in Thread]