|
From: | Rob Savoye |
Subject: | Re: [Gnash-commit] gnash ChangeLog libamf/amf.cpp server/vm/Action... |
Date: | Sun, 18 May 2008 17:59:05 +0200 |
User-agent: | Thunderbird 2.0.0.9 (X11/20071031) |
strk wrote:
I'm fine to revert, but the patch DOES fix a bug in amf.cpp. The patch is the code used 'delete' against memory allocated by 'malloc' (deep in strnup).
It's a valgrind bug, not an amf.cpp one.
Will wait for confirmation before reverting :>
Like I suggested, if you're gonna fix this bug, please fix it right. :-) Type casting tmpptr to name, rather than allocating memory via strndup() it the way it should work.
- rob -
[Prev in Thread] | Current Thread | [Next in Thread] |