Re: [Gnash-commit] gnash ChangeLog server/asobj/NetStreamFfmpeg.cp... [gnash_0_8_3_branch]

[Sandro Santilli]

On Wed, May 21, 2008 at 11:35:49AM +0000, Sandro Santilli wrote:
> CVSROOT:      /sources/gnash
> Module name:  gnash
> Branch:               gnash_0_8_3_branch
> Changes by:   Sandro Santilli <strk>  08/05/21 11:35:49
> 
> Modified files:
>       .              : ChangeLog 
>       server/asobj   : NetStreamFfmpeg.cpp NetStreamFfmpeg.h 
> 
> Log message:
>         Don't lock input mutex while holding it on ::startPlayback.
>         Doesn't fix the .join() hung, but helgrind is kind of happier.

I was wrong, isn't happy yet.
I tracked this down to be due to av_open_input_stream() call
internally calling ::readPacket

When reducing scope of the mutex I get horrible errors from av lib:

  Compiler did not align stack variables. Libavcodec has been miscompiled
  and may be very slow or crash. This is not a bug in libavcodec,
  but in the compiler. Do not report crashes to FFmpeg developers.

Don't really know where to put my hands...

--strk;