[Gnash-commit] gnash ChangeLog server/asobj/Global.cpp

[Benjamin Wolsey]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Benjamin Wolsey <bwy>   08/05/29 18:10:53

Modified files:
        .              : ChangeLog 
        server/asobj   : Global.cpp 

Log message:
        Add comments for undefined 'this'. I'm not really inclined
        to do any workarounds until the testsuite helps here a bit.
        The change I made before, which might not be compatible
        behaviour, didn't cause any failures in the testsuite
        and is easy to revert.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.6764&r2=1.6765
http://cvs.savannah.gnu.org/viewcvs/gnash/server/asobj/Global.cpp?cvsroot=gnash&r1=1.131&r2=1.132

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.6764
retrieving revision 1.6765
diff -u -b -r1.6764 -r1.6765
--- ChangeLog   29 May 2008 15:40:43 -0000      1.6764
+++ ChangeLog   29 May 2008 18:10:52 -0000      1.6765
@@ -1,5 +1,9 @@
 2008-05-29 Benjamin Wolsey <address@hidden>
 
+       * server/asobj/Global.cpp: add note on undefined 'this'.
+
+2008-05-29 Benjamin Wolsey <address@hidden>
+
        * server/vm/action.cpp: register_component is not the way to
          register extensions.
        * server/parser/character_def.cpp: drop unused forward declaration.

Index: server/asobj/Global.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/asobj/Global.cpp,v
retrieving revision 1.131
retrieving revision 1.132
diff -u -b -r1.131 -r1.132
--- server/asobj/Global.cpp     29 May 2008 12:44:29 -0000      1.131
+++ server/asobj/Global.cpp     29 May 2008 18:10:52 -0000      1.132
@@ -586,6 +586,11 @@
 as_value
 as_global_asnative(const fn_call& fn)
 {
+
+    // Note: it's possible for 'this' to be undefined in ActionScript,
+    // which would make this call return undefined. TODO: test it in
+    // the testsuite! It's not even certain whether Gnash has implemented
+    // an undefined this pointer.
     boost::intrusive_ptr<as_object> ptr = ensureType<as_object>(fn.this_ptr);
 
     as_value ret;