On Sun, Aug 10, 2008 at 11:31 PM, Benjamin Wolsey
<address@hidden> wrote:
> + register_tag_loader(SWF::SYMBOLCLASS, symbol_class_loader); //
There was a policy of putting new tag loaders in their own file in
libcore/swf, which would make this SymbolClassTag::loader. I've been
doing it for tags I've added recently. Is there general agreement on
this? I'd rather not have two different systems going at the same time.
Because it's such a small tag, a header only would surely be enough.
> + boost::uint16_t num_symbols = in->read_u16();
If each read isn't prefaced with a corresponding ensureBytes call,
malformed SWFs can make Gnash read past the end of the tag, which tends
to result in a segfault.
That makes sense, I can make those changes.
> + in->read_string(name);
I've just changed the tag_loader function signature to take SWFStream as
a reference.
I'll try and merge your commit into the avm2 branch.
-Tom