gnash-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Gnash-commit] Debugger


From: Benjamin Wolsey
Subject: [Gnash-commit] Debugger
Date: Sun, 31 Aug 2008 20:43:53 +0200

Am Samstag, den 30.08.2008, 00:01 +0200 schrieb Sandro Santilli:
> ------------------------------------------------------------
> revno: 9649
> committer: Sandro Santilli <address@hidden>
> branch nick: trunk
> timestamp: Sat 2008-08-30 00:01:46 +0200
> message:
>   Change AVM1 stack management to allow smashing as expected.
>   Fix build with older ffmpeg.

This commit breaks the debugger. It's not that serious, as it only fails
because of the change from m_stack to _stack and the change in type.
It's slightly more of an issue now I've made _stack private (the
debugger is the only class that needs access).

I'm not sure if there's any danger of the debugger being really useful
or not in the near future. The primary question is: is there much point
in continuing to support it until it's had a bit of attention? (I've
never used it, so if anyone finds it useful and/or it actually works,
the answer is of course 'yes').

If it is useful, I'd suggest Debugger be made a friend of the classes it
needs access to, to avoid exposing more than necessary or providing
accessors to private data.

bwy

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil


reply via email to

[Prev in Thread] Current Thread [Next in Thread]