[Gnash-commit] /srv/bzr/gnash/trunk r9818: Missing commit from yesterday.

[Benjamin Wolsey]

------------------------------------------------------------
revno: 9818
committer: Benjamin Wolsey <address@hidden>
branch nick: trunk
timestamp: Tue 2008-09-23 10:41:44 +0200
message:
  Missing commit from yesterday.
  
  Update README a bit.
modified:
  README
  libcore/asobj/flash/geom_pkg.cpp
  testsuite/actionscript.all/MovieClip.as
    ------------------------------------------------------------
    revno: 9813.1.1
    committer: Benjamin Wolsey <address@hidden>
    branch nick: work
    timestamp: Tue 2008-09-23 10:13:54 +0200
    message:
      Don't load the geom.Transform class for SWF7 or below (see tests in 
      swfdec and actionscript.all).
    modified:
      libcore/asobj/flash/geom_pkg.cpp
    ------------------------------------------------------------
    revno: 9813.1.2
    committer: Benjamin Wolsey <address@hidden>
    branch nick: work
    timestamp: Tue 2008-09-23 10:15:42 +0200
    message:
      Passing test in MovieClip.as
    modified:
      testsuite/actionscript.all/MovieClip.as
    ------------------------------------------------------------
    revno: 9813.1.3
    committer: Benjamin Wolsey <address@hidden>
    branch nick: work
    timestamp: Tue 2008-09-23 10:15:54 +0200
    message:
      Update README (SWF version support, browser support, CVS->bzr, Gnash 
release
      version).
    modified:
      README

=== modified file 'README'
--- a/README    2008-09-12 21:18:45 +0000
+++ b/README    2008-09-23 08:15:54 +0000
@@ -2,11 +2,11 @@
                    Gnash: the GNU SWF Player
 
 Gnash is a player for animated "movies" in the Macromedia Shockwave Flash
-(.swf) format.  It can be run as a graphical application, as a Web browser
+(SWF) format.  It can be run as a graphical application, as a Web browser
 plugin, or as a library used by other programs.  It is not yet complete;
-it does not correctly handle every .swf file.
+it does not correctly handle every SWF file.
 
-This is the README file for the Gnash-0.8.3 release (or CVS snapshot).
+This is the README file for the Gnash-0.8.4 release (or bzr snapshot).
 
 Gnash is originally based on the code of GameSWF, by Thatcher Ulrich.
 GameSWF was the most advanced among free SWF players; it implemented a
@@ -25,17 +25,20 @@
 SWF Support:
 --------------
 
-Many SWF movies play fine in Gnash.  Many others do not.  In particular,
-SWF movies that are used for browser navigation may still have a few
-issues with some URLs left.  Most SWF based navigation of a web site
-should work.
-
-Gnash supports most SWF opcodes up to SWF version 7, and a wide sampling
-of ActionScript classes for SWF version 7.  All the core ones are
-implemented, and many of the newer ones work, but may be missing some of
-their methods.  All unimplemented opcodes and ActionScript classes and
-methods print a warning when using -v with gnash or gprocessor.  Using
-gprocessor -v is a quick way to see why a movie isn't playing correctly.
+Many SWF movies play fine in Gnash.  Many others do not.  Occasionally, 
+SWF movies that are used for browser navigation may fail. Almost all
+SWF-based web-site navigation should work.
+
+Gnash supports practically all SWF opcodes and most ActionScript classes up
+to SWF version 7. Gnash also supports some of the most important SWF
+version 8 ActionScript classes. There is no support yet for ActionScript
+3 (ABC blocks) or AVM2, which were introduced in SWF version 9. Despite
+this, Gnash can play most SWF8 and many SWF9 movies, because not all rely on
+unimplemented features.
+
+All unimplemented opcodes and ActionScript methods should print a warning
+when using -v with gnash or gprocessor.  Running gprocessor -v is often an
+easy way to see why a movie isn't playing correctly.
 
 Currently streaming video for some video sharing sites like Lulu.tv,
 or YouTube.com, does work. Your mileage with other sites may vary, but
@@ -47,19 +50,24 @@
 
 The plugin correctly installs itself into Mozilla, Firefox, or Konqueror.
 It can play some SWF files in cooperation with the browser. It
-should work with any browser that supports the of Mozilla's NSPR API and
+should work with any browser that supports Mozilla's NSPR API and
 plugin SDK. It has been tested with Mozilla 1.7.13 with gtk2 (won't work with
-gtk1 due to the NSAPI used), Firefox 1.0.x, Firefox 1.5.x, and Firefox 2.x.
-
-Some web pages have Internet Explorer-specific Javascript that fail
-in Firefox, which prevents the plugin from being loaded. In these cases
+gtk1 due to the NSAPI used), Firefox 1.0.x, Firefox 1.5.x, Firefox 2.x, and
+Firefox 3.x.
+
+Gnash runs equally well in 32-bit and 64-bit environments, so works without
+any issues as a 64-bit plugin.
+
+Occasionally, web pages may have Internet Explorer-specific Javascript that
+fails in other browsers, thus preventing the plugin from being loaded. These
+cases are now extremely rare, because web developers are more knowledgable
+about supporting multiple browsers and because free, standardised
+flash-embedding scripts are widely used. If you do encounter faulty javascript,
 "view source" and then use wget to grab the movie for testing.
 
-By default, the configure script looks for the GtkGl extension, and
-if that can't be found, it defaults to using SDL. The plugin works by
-forking and running the standalone player, so whichever graphics library
-Gnash uses will also be used by the plugin. As an alternate to SDL,
-Gnash also now has FLTK2 support.
+The plugin works by forking and running the standalone player, so whichever
+graphics library Gnash uses will also be used by the plugin. As an alternate
+to SDL, Gnash also now has FLTK2 support.
 
 The GTK version has full event handling, and supports a right-click
 mouse menu to control the movie. The SDL version has no event
@@ -70,7 +78,7 @@
 
 Configure with --with-plugindir= to set the directory that "make
 install" will install the plugin in. By default it will be installed
-in the user's .mozilla/plugins or .firefox/plugins directory.
+in the user's .mozilla/plugins directory.
 
 Platforms Supported:
 --------------------
@@ -85,8 +93,8 @@
 There are ports of the standalone player to Darwin and Win32. Both
 require adding the dependent libraries Gnash needs. Work has started
 on a native Darwin (Aqua/Carbon/OpenGL) GUI so most of these packages
-won't be required. The win32 player can be built with VC++, or
-Mingw32. 
+won't be required. The win32 player can be built with Mingw32 and ought
+to be compilable with VC++ (but this has not been confirmed recently). 
 
 Gnash has also been ported to a variety of embedded devices, most
 running variations of OpenEmbedded. These include several custom
@@ -156,10 +164,6 @@
 development packages installed. This now installs a KDE executable
 called "klash" that is used by this plugin.
 
-As of ffmpeg version 51.40.4, the swscale implementation will be used
-instead of img_convert. Note that using when using ffmpeg version
-51.40.4, Gnash won't link.
-
 The Gnash Community:
 --------------------
 
@@ -204,6 +208,6 @@
 https://savannah.gnu.org/bugs/?group=gnash.  Please include the operating
 system name and version, and which gnash version you are using, in your
 bug reports. Please try to reproduce your bug reports with the most
-recent version of Gnash in CVS, as bugs are fixed there that may be
+recent version of Gnash in bzr, as bugs are fixed there that may be
 broken in a standard release.
 

=== modified file 'libcore/asobj/flash/geom_pkg.cpp'
--- a/libcore/asobj/flash/geom_pkg.cpp  2008-05-05 14:35:02 +0000
+++ b/libcore/asobj/flash/geom_pkg.cpp  2008-09-23 08:13:54 +0000
@@ -32,16 +32,23 @@
 namespace gnash {
 
 as_value
-get_flash_geom_package(const fn_call& /*fn*/)
+get_flash_geom_package(const fn_call& fn)
 {
        log_debug("Loading flash.geom package");
 
+       const int version = fn.env().getVM().getSWFVersion();
+
        as_object* pkg = new as_object(getObjectInterface());
 
        ColorTransform_class_init(*pkg);
        Matrix_class_init(*pkg);
        Point_class_init(*pkg);
        Rectangle_class_init(*pkg);
+
+    // Transform is never available below SWF7, even
+    // when prop flags are set.        
+       if (version < 8) return pkg;
+               
        Transform_class_init(*pkg);
 
        return pkg;

=== modified file 'testsuite/actionscript.all/MovieClip.as'
--- a/testsuite/actionscript.all/MovieClip.as   2008-09-23 08:09:21 +0000
+++ b/testsuite/actionscript.all/MovieClip.as   2008-09-23 08:41:44 +0000
@@ -1376,7 +1376,7 @@
 props = []; for (var i in _root.transform) props.push(i); props.sort();
 xcheck_equals(props.toString(), 
"colorTransform,concatenatedColorTransform,concatenatedMatrix,matrix,pixelBounds");
 
-xcheck_equals(typeof(_root.transform.colorTransform), 'object');
+check_equals(typeof(_root.transform.colorTransform), 'object');
 // TODO: test colorTransform
 
 xcheck_equals(typeof(_root.transform.concatenatedColorTransform), 'object');