[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnash-commit] /srv/bzr/gnash/avm2 r9579: Add some preprocessor macr
Re: [Gnash-commit] /srv/bzr/gnash/avm2 r9579: Add some preprocessor macros to allow String.as to be converted to .hx.
Thu, 2 Oct 2008 00:29:30 +0800
On Wed, Oct 1, 2008 at 4:00 PM, strk <address@hidden> wrote:
> On Wed, Oct 01, 2008 at 01:10:38PM +0800, Tom Stellard wrote:
>> revno: 9579
>> committer: Tom Stellard <address@hidden>
>> branch nick: gnash_dev
>> timestamp: Wed 2008-10-01 13:10:38 +0800
>> Add some preprocessor macros to allow String.as to be converted to .hx.
> No please ! :)
> Sounds too much of a change for my taste.
> The convertion should require no changes in the .as files IMHO.
> We often add new tests to existing files, will be hard to maintain
> if we have to think about haxe too there.
> Can you think about a less intrusive way to do that ?
I think I can improve my script, so that I won't need all of that
preprocessor stuff. However, I had some trouble when trying to
include check.as. There is one check.as file in
testsuite/actionscript.all for the actionscipt files, and a check.as
file in testsuite/actionscript.all/haxe-swf9 for the haxe files. I
thought I was setting the correct include directory here in the
Makefile (located in testsuite/actionscript.all):
HAXE_DIR = $(srcdir)/haxe-swf9
HAXE_CPP = $(CPP) -DHAXE -DOUTPUT_VERSION=9 -x c -P -I$(HAXE_DIR)
But when I actually run the preprocessor, it always uses the check.as
file in the testsuite/actionscript.all directory. That is why I added
the #ifdefs around the #include "check.as" here:
Can anyone spot what I am doing wrong?