[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] /srv/bzr/gnash/trunk r11325: updated testsuites and f

From: Benjamin Wolsey
Subject: Re: [Gnash-commit] /srv/bzr/gnash/trunk r11325: updated testsuites and findcam/mic utilities they should no longer segfault
Date: Tue, 28 Jul 2009 22:22:06 +0200

> === modified file 'testsuite/libmedia.all/test_audioinput.cpp'

> +#include <unistd.h>

>      sleep(5);

unistd.h isn't a C++ standard header, and sleep is a non-standard (I
don't think it's even even posix) function. For this we have the
compatibility header GnashSleep and the function gnashSleep(), which
unfortunately takes an argument in microseconds. This avoids breaking
the testsuite for some OS that is not Linux.

> +    if (unlink(file.c_str()) == 0)

unlink is already used in a few places, including log.cpp. I wonder how
MSVC, for instance, which uses _unlink(), manages to build Gnash. It is
probably worth adding it to a compatibility header somewhere. including
GnashFDSystemHeaders instead of <unistd.h> would probably do, though it
is more a file system function than a file-descriptor function. These
various people who allegedly build under MSVC could come forward with
some patches.

The current release of Gnash is 0.8.5

Benjamin Wolsey, Software Developer -

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil

reply via email to

[Prev in Thread] Current Thread [Next in Thread]