Re: [Gnash-commit] /srv/bzr/gnash/trunk r11348: Modified tabStops property and should now return proper return type

[Benjamin Wolsey]

>   testsuite/libmedia.all/test_videoinput.cpp

This commit also removes most of the test_videoinput test, which I guess
wasn't intended.

> === modified file '.bzrignore'
> --- a/.bzrignore      2009-05-19 10:04:09 +0000
> +++ b/.bzrignore      2009-07-30 21:34:40 +0000
> @@ -336,3 +336,5 @@
>  testsuite/libnet.all/generate_amfbins
>  gui/gtk_widget/gnash.c
>  py-compile
> +testsuite/libmedia.all/test_videoinput.cpp
> +testsuite/libmedia.all/test_videoinput.cpp

And ignores some files.

> +// ADDED

> +// ADDED

Some messy comments left in.

> === modified file 'libcore/TextField.h'
> --- a/libcore/TextField.h     2009-07-30 21:27:22 +0000
> +++ b/libcore/TextField.h     2009-07-30 21:37:46 +0000
> @@ -24,6 +24,7 @@
>  #include "Range2d.h"
>  #include "rect.h" // for inlines
>  #include "Font.h" // for visibility of font add_ref/drop_ref
> +#include "Array_as.h"

There's no use for this include. Doing things like that eventually
causes longer compiling times and eventually creates a proper mess.

> +tf = new TextFormat();
> +
> +o = {};
> +//o.valueOf = function() { return 6; };
> +o.toString = function() { return "string"; };
> +
> +a = [ o ];
> +
> +tf.tabStops = a;
> +trace(tf.tabStops);
> +

That isn't a test. It is a test as soon as you use check_equals with the
expected output.

--
Free Flash, use Gnash
http://www.gnu.org/software/gnash/

Benjamin Wolsey, Software Developer - http://benjaminwolsey.de

signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil