[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnash-commit] /srv/bzr/gnash/trunk r11654: Finally fix testsuite fo
Re: [Gnash-commit] /srv/bzr/gnash/trunk r11654: Finally fix testsuite for ffmpeg by introducing a proper AudioInput interface.
Fri, 27 Nov 2009 16:27:48 +0100
> Yeah! Can't wait to have some time to look at this ! :)
Don't expect too much - it only stores the values somewhere and pretends
to be an input device, though without any actual input data because no
one ever spent any time working out how usefully to implement it.
The advantage is not that it does anything useful, but that it passes
the testsuite without ifdefs in libcore and shows some of, but not all,
the things that a proper AudioInput would have to implement.
That also means that it should be feasible now to set the media handler
There is also some need to work out where to store the input devices,
because Camera and Microphone are the last two classes to derive from
as_object when they shouldn't do.
(Function / as_function also does this, but that shouldn't be too much
of a problem).
The requirement is that Microphone.get(x) should generally return the
same object, *but* with the proviso that microphones can be added and
removed; what happens when you do Microphone.get(1), unplug Microphone
0, and then do Microphone.get(1) again? Does the first Microphone object
become invalidated? Does it become the same as (now) Microphone.get(0)?
Microphones also have an index property; can this change? None of this
can really be tested automatically because it involves either manually
plugging hardware, or OS-dependent creation of audio inputs, but
wouldn't be hard to do manually (anyone reading with some spare time
could do it - any volunteers?).
At any rate, we need to store a list of input devices that can be
associated with a single as_object somehow and returned when requested.
Exactly how to do it depends on the answer to the questions above.
Yes, YouTube does work in Gnash (well it did until they upped the
Benjamin Wolsey, Software Developer - http://benjaminwolsey.de
Description: Dies ist ein digital signierter Nachrichtenteil