Re: [Gnash-commit] /srv/bzr/gnash/trunk r11659: Adapted the OS4 Gui to the recent changes.

[Benjamin Wolsey]

>  void 
> -AOS4AggGlue::saveOrigiginalDimension(int width, int height)
> +AOS4AggGlue::saveOrigiginalDimension(int width, int height, int xPosition, 
> int yPosition)

Not that it's anything to do with me, but shouldn't that be
saveOriginalDimension?

> +    const int32_t gain = clamp(fn.arg(0).to_int(), (boost::int32_t)0, 
> (boost::int32_t)100);

Please use an explicit template argument instead of ugly C-style casts
in these cases: clamp<boost::int32_t>(...) will compile without explicit
casting.

>    const int timeout = std::max(fn.arg(1).to_int(), (boost::int32_t)0);

Same here - std::max<boost::int32_t>(...).

bwy

--
Free Flash, use Gnash
http://www.gnu.org/software/gnash/

Benjamin Wolsey, Software Developer - http://benjaminwolsey.de

signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil