Re: [Gnash-commit] /srv/bzr/gnash/trunk r11960: struct -> class reconstruction

[Markus Gothe]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Which works, because that's how structs works in C++, consider someone  
reading the code coming from the world of C then. It might confuse  
them at the first glimpse, as well as I think it's more convenient  to  
keep things uniform.

I hadn't noticed it if it wasn't for:

In file included from AMFConverter.cpp:25:
AMFConverter.h: At global scope:
AMFConverter.h:150: error: ‘gnash::AMF::Type’ has not been declared
AMFConverter.h:150: error: ‘NOTYPE’ is not a member of ‘gnash::AMF’
AMFConverter.cpp: In member function ‘bool  
gnash::AMF::Writer::writePropertyName(const std::string&)’:

etc...

//Markus

On 23 Feb 2010, at 23:48, Benjamin Wolsey wrote:

> >  struct -> class reconstruction
>
> Don't, please. I use structs deliberately when there is no private  
> data.
>
> --
> Use Gnash, the GNU Flash Player!
> http://www.gnu.org/software/gnash/
>
> Benjamin Wolsey, Software Developer - http://benjaminwolsey.de
> C++ and Open-Source Flash blog - http://www.benjaminwolsey.de/bwysblog
>
> xmpp:address@hidden
> http://identi.ca/bwy

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.12 (Darwin)

iD8DBQFLhMfN6I0XmJx2NrwRAheSAKC1/KdJUpskXM3TyFm+noJ3zD4GOACfcRx/
1Fxphcvgph7Lm1YeQp/IcB8=
=4A1R
-----END PGP SIGNATURE-----