[Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_start-44-g37a2eec

[Sandro Santilli]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Gnash".

The branch, master has been updated
       via  37a2eec77ac64d255c0f64a6cf1fd83ea74e3d70 (commit)
      from  5dd53262b53d22e3052cb42cc626a254457d0d17 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit//commit/?id=37a2eec77ac64d255c0f64a6cf1fd83ea74e3d70


commit 37a2eec77ac64d255c0f64a6cf1fd83ea74e3d70
Author: Sandro Santilli <address@hidden>
Date:   Fri Feb 11 13:54:24 2011 +0100

    Use "_self" as a default target for getURL when no target is given. Fixes 
bug #32425

diff --git a/plugin/npapi/plugin.cpp b/plugin/npapi/plugin.cpp
index a4e0ba1..02a2482 100644
--- a/plugin/npapi/plugin.cpp
+++ b/plugin/npapi/plugin.cpp
@@ -797,19 +797,23 @@ nsPluginInstance::processPlayerRequest(gchar* buf, gsize 
linelen)
         std::string op = NPStringToString(NPVARIANT_TO_STRING(
                                               invoke->args[1].get()));
         // The third is the optional target, which is something like
-        // _blank or _self. NONE means no target.
+        // _blank or _self.
         std::string target;
+
         // The fourth is the optional data. If there is data, the target
         // field is always set so this argument is on the correct index.
-        // No target is "NONE".
         std::string data;
+
         if (invoke->args.size() >= 3) {
             target = NPStringToString(NPVARIANT_TO_STRING(
                                           invoke->args[2].get()));
-            if (target == "NONE") {
-                target.clear();
-            }
         }
+
+        // An empty target defaults to "_self"
+        // This is _required_ for chromium,
+        // see https://savannah.gnu.org/bugs/?32425
+        if ( target.empty() ) target = "_self";
+
         if (invoke->args.size() == 4) {
             data = NPStringToString(NPVARIANT_TO_STRING(
                                         invoke->args[3].get()));

-----------------------------------------------------------------------

Summary of changes:
 plugin/npapi/plugin.cpp |   14 +++++++++-----
 1 files changed, 9 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
Gnash