Re: [Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_start-62-g3240ec3

[Benjamin Wolsey]

>         // When in non-blocking mode, we'll get several iterations of this
>         // loop while waiting for data. if data never arrives, we'd be stuck
>         // looping here forever, so this is our escape from that loop.
>         if (retries-- <= 0) {
>             gnash::log_error("Too many attempts to read from the player!");
>             return false;
>         }
> 
> The change above drops the return ...
> 

Either the comment is now wrong or the commit was wrong. Also, the
variable 'retries' is now only useful for printing an error message
repeatedly, which after the commit appears not to be an error.

Can we have it fixed before the release?

bwy

-- 
--
Free Flash, use Gnash
http://www.gnu.org/software/gnash/

Benjamin Wolsey, Software Developer - http://benjaminwolsey.de
C++ and Open-Source Flash blog - http://www.benjaminwolsey.de/bwysblog

xmpp:address@hidden
http://identi.ca/bwy

signature.asc
Description: This is a digitally signed message part