[Gnash-commit] [patch #7533] [PATCH] AbcBlock.h: checkBounds should check for negative values

[Mj Mendoza IV]

Follow-up Comment #2, patch #7533 (project gnash):

I believe so, but I'm only trying to address a TODO inside
`libcore/vm/Machine.cpp' at line 64:

<code>
/// TODO: it's quite possible for a malformed SWF to ask for out-of-bounds
/// pool access, although at the moment it's mainly Gnash bugs causing this.
/// Throwing an exception is good here, but it's not clear which one.
</code>

All `pool_{datatype}' are using `try/catch' to address the above TODO. But
each `{datatype}PoolAt' are already using the checkBounds, which is not
checking for negative values.

My suggestion is for `checkBounds' to implement checking of negative values so
these try/catches will be removed.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?7533>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/