[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Gnash-commit] [bug #33754] ActionAddTyped with short stack
|
From: |
Sandro Santilli |
|
Subject: |
[Gnash-commit] [bug #33754] ActionAddTyped with short stack |
|
Date: |
Sat, 16 Jul 2011 15:42:14 +0000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/534.30 (KHTML, like Gecko) Ubuntu/10.04 Chromium/12.0.742.112 Chrome/12.0.742.112 Safari/534.30 |
Follow-up Comment #4, bug #33754 (project gnash):
I suspect we have this problem for _every_ opcode.
Problem is we assume there's stuff on the stack, so rather than doing pop,pop
and push we take references to the operators from the stack, override the
second-to-last as the return and we drop the last one.
When the stack doesn't have those items we basically override a temporary
as_value (not on the stack) and we drop the last one (possibly the only one on
the stack).
Proper solution here would be either checking how many items we have or just
pop,pop,push ...
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?33754>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/