[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnash-commit] [SCM] Gnash branch, noise, updated. release_0_8_9_fin
From: |
Sandro Santilli |
Subject: |
Re: [Gnash-commit] [SCM] Gnash branch, noise, updated. release_0_8_9_final-1175-g80baf93 |
Date: |
Wed, 14 Sep 2011 14:15:02 +0200 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Wed, Sep 14, 2011 at 12:08:11AM +0000, Rob Savoye wrote:
> commit 40e8f708b49b71839681973923efbe72d5247962
> Author: Rob Savoye <address@hidden>
> Date: Tue Sep 13 17:58:40 2011 -0600
>
> use a regualr iterator instead of std::for_each, so we can do loop
> through all the liveChars only once
>
> diff --git a/libcore/movie_root.cpp b/libcore/movie_root.cpp
> index 52e9101..c652de7 100644
> --- a/libcore/movie_root.cpp
> +++ b/libcore/movie_root.cpp
> @@ -2056,11 +2056,12 @@ movie_root::advanceLiveChars()
> "the global list", _liveChars.size());
> #endif
>
> - std::for_each(_liveChars.begin(), _liveChars.end(),
> - boost::bind(advanceLiveChar, _1));
> -
> - std::for_each(_liveChars.begin(), _liveChars.end(),
> - boost::bind(notifyLoad, _1));
> + // Iterate through the array once, instead of twice like it used to be.
> + LiveChars::iterator it;
> + for (it=_liveChars.begin(); it != _liveChars.end(); ++it) {
> + advanceLiveChar(*it);
> + notifyLoad(*it);
> + }
> }
>
> void
Note that the above is a sensible spot as per action execution order.
The notifyLoad loop was added to fix movies made with Captivative tool,
see https://savannah.gnu.org/bugs/index.php?33521
Please make sure the whole testsuite still succeeds with your change
and also the live movie in the bug above.
--strk;
() Free GIS & Flash consultant/developer
/\ http://strk.keybit.net/services.html