[Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_final-1810-g5ae8239

[Sandro Santilli]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Gnash".

The branch, master has been updated
       via  5ae8239d41c7687372bf5cfa9fd90037bcd6c7c9 (commit)
      from  2d34de4767be918053ddb4392d7f55ca140a2078 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit//commit/?id=5ae8239d41c7687372bf5cfa9fd90037bcd6c7c9


commit 5ae8239d41c7687372bf5cfa9fd90037bcd6c7c9
Author: Sandro Santilli <address@hidden>
Date:   Sat Nov 2 09:06:23 2013 +0100

    Fix segfault on exit due to XMLNode destructor noise
    
    See https://savannah.gnu.org/bugs/?40439

diff --git a/libcore/asobj/XMLNode_as.cpp b/libcore/asobj/XMLNode_as.cpp
index 70826b2..9865783 100644
--- a/libcore/asobj/XMLNode_as.cpp
+++ b/libcore/asobj/XMLNode_as.cpp
@@ -115,7 +115,12 @@ XMLNode_as::~XMLNode_as()
     // In practice it is quite likely that the child will be garbage-collected
     // before the parent. See Savannah bug #39404.
     if (_parent ) {
-        _parent->removeChild(this);
+        // NOTE: do not removeChild as it makes too much
+        //       noise including calls to string_table
+        //       (due to updateChildNodes)
+        // See https://savannah.gnu.org/bugs/?40439
+        _parent->_children.remove(this);
+        _parent = 0; 
     }
 
     clearChildren();

-----------------------------------------------------------------------

Summary of changes:
 libcore/asobj/XMLNode_as.cpp |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Gnash