[Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_final-1974-gde5c720

[Petter Reinholdtsen]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Gnash".

The branch, master has been updated
       via  de5c7201f93702938bcd8efcbf8342789043d7bd (commit)
       via  e95429d8f0b1b324a3f22a5978bc2afc84276f7d (commit)
       via  05bd3dd93820058f4f649b60d9fb97c93fdc4ce0 (commit)
      from  41590ecb73f8d798d09b45aad9d97d4149213d01 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit//commit/?id=de5c7201f93702938bcd8efcbf8342789043d7bd


commit de5c7201f93702938bcd8efcbf8342789043d7bd
Author: Petter Reinholdtsen <address@hidden>
Date:   Tue May 6 10:34:21 2014 +0200

    Make sure to initialize GtkTreeIter structs to zero before they are
    used (Coverity CID 1149256).

diff --git a/gui/gtk/gtk.cpp b/gui/gtk/gtk.cpp
index 0db93c0..3311a70 100644
--- a/gui/gtk/gtk.cpp
+++ b/gui/gtk/gtk.cpp
@@ -778,9 +778,9 @@ GtkGui::makeTreeModel(std::auto_ptr<movie_root::InfoTree> 
treepointer)
     GtkTreeStore *model = gtk_tree_store_new (NUM_COLUMNS,
                          G_TYPE_STRING, G_TYPE_STRING);
     
-    GtkTreeIter iter;
-    GtkTreeIter child_iter;
-    GtkTreeIter parent_iter;
+    GtkTreeIter iter = {0, 0, 0, 0};
+    GtkTreeIter child_iter = {0, 0, 0, 0};
+    GtkTreeIter parent_iter = {0, 0, 0, 0};
 
     // Depth within the *GTK* tree.
     int depth = 0;    

http://git.savannah.gnu.org/cgit//commit/?id=e95429d8f0b1b324a3f22a5978bc2afc84276f7d


commit e95429d8f0b1b324a3f22a5978bc2afc84276f7d
Author: Petter Reinholdtsen <address@hidden>
Date:   Tue May 6 10:19:53 2014 +0200

    Report a failure if unable to open the input file (Coverity CID
    1211834).

diff --git a/testsuite/libbase.all/NoSeekFileTest.cpp 
b/testsuite/libbase.all/NoSeekFileTest.cpp
index 6b0eb8f..fb63911 100644
--- a/testsuite/libbase.all/NoSeekFileTest.cpp
+++ b/testsuite/libbase.all/NoSeekFileTest.cpp
@@ -137,6 +137,10 @@ trymain(int /*argc*/, char** /*argv*/)
        int fd = open(input, O_RDONLY);
        int raw = open(input, O_RDONLY);
 
+       if (fd < 0 || raw < 0) {
+           runtest.fail("Unable to open input file");
+       }
+
        dup2(fd, 0);
        close(fd);
 

http://git.savannah.gnu.org/cgit//commit/?id=05bd3dd93820058f4f649b60d9fb97c93fdc4ce0


commit 05bd3dd93820058f4f649b60d9fb97c93fdc4ce0
Author: Petter Reinholdtsen <address@hidden>
Date:   Tue May 6 10:15:43 2014 +0200

    Make sure to close file descriptors after user (Coverity CIDs 1211835,
    1211836).

diff --git a/testsuite/libbase.all/NoSeekFileTest.cpp 
b/testsuite/libbase.all/NoSeekFileTest.cpp
index 5f0388c..6b0eb8f 100644
--- a/testsuite/libbase.all/NoSeekFileTest.cpp
+++ b/testsuite/libbase.all/NoSeekFileTest.cpp
@@ -138,6 +138,7 @@ trymain(int /*argc*/, char** /*argv*/)
        int raw = open(input, O_RDONLY);
 
        dup2(fd, 0);
+       close(fd);
 
        gnash::IOChannel* reader = gnash::noseek_fd_adapter::make_stream(0, 
cachename);
        assert(reader);
@@ -153,6 +154,7 @@ trymain(int /*argc*/, char** /*argv*/)
     std::auto_ptr<gnash::IOChannel> orig = gnash::makeFileChannel(f, false);
        lseek(raw, 0, SEEK_SET);
        compare_reads(orig.get(), raw, "cache", "raw");
+       close(raw);
 
 
     if (sizeof(size_t) != sizeof(std::streamoff)) {

-----------------------------------------------------------------------

Summary of changes:
 gui/gtk/gtk.cpp                          |    6 +++---
 testsuite/libbase.all/NoSeekFileTest.cpp |    6 ++++++
 2 files changed, 9 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
Gnash