Re: [Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_final-2083-g223b921

[Bastiaan Jacques]

On Fri, 30 May 2014, Richard Wilbur wrote:

> >      drawLineTo(std::int32_t dx, std::int32_t dy)
> >      {
> > -        m_edges.push_back(Edge(dx, dy, dx, dy));
> > +        m_edges.emplace_back(dx, dy, dx, dy);
> >      }
>
> This looks like a terribly short line, length = 0.  Do we have a
> position to start or continue drawing from, on our way to the point
> (dx, dy)?

Yes, obviously the idea is that only the terminating point of the line
is specified and the origin has been previously defined. This works just
like cairo_line_to(), for example. Because the definition of an Edge in
Gnash implies that every line is a curve, the control point must be
stored. It would probably be more elegant to store the control point
only for actual curves; patches are welcome.

Bastiaan