[Gnash-commit] [bug #46607] Embedded audio quality degradation

[Sandro Santilli]

URL:
  <http://savannah.gnu.org/bugs/?46607>

                 Summary: Embedded audio quality degradation
                 Project: Gnash - The GNU Flash player
            Submitted by: strk
            Submitted on: Fri 04 Dec 2015 11:44:34 PM CET
                Category: sound
                Severity: 3 - Normal
                 Release: master
                  Status: None
                 Privacy: Public
             Assigned to: bjacques
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

I've found a movie which plays stuttering and bisecting got to this point:

a9f7f743c66f2f36d81c348da238d94877473372 is the first bad commit
commit a9f7f743c66f2f36d81c348da238d94877473372
Author: Bastiaan Jacques <address@hidden>
Date:   Sun Jun 15 20:09:12 2014 +0200

    Reduce malloc() churn for SWF-embedded audio.
    
    Decoded data from audio sources stored inside SWFs are decoded and
    stored in a growing buffer. This buffer is appended to as small
    chunks of data become available. In order to store the additional
    data, a new buffer big enough to contain all the data is allocated.
    A minute of audio corresponds to about 10MB of decoded data. The
    ensuing (re)allocation of such a large buffer adds significantly to
    the resource pressure on the system.
    
    This change alters the situation so that instead of allocating a new
    buffer, each buffer is added to a list as-is, at the cost of having
    to keep track of reads in more detail.

:040000 040000 45eed7e653f151eeaf7baf2187d08887b6c169c5
c61e4016939188ae645ff56a9d7a9c972fb241d8 M      libbase
:040000 040000 c5a5e6700aac7e4a084a4fe3fe463469c4cde316
5a86380f1b008ecc77da09db22b10e3bcd61c71e M      libsound





    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46607>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/