[Gnash-commit] [bug #46607] Embedded audio quality degradation

[Sandro Santilli]

Follow-up Comment #13, bug #46607 (project gnash):

I've looked closely at bastiann code and found the problem being in the
LiveSound::consumeInput function. I have a patch that fixes that
implementation so we might go back to the new implementation, but would like a
review from Bastiaan.

The patch applies to the code before the revert.
I'm attaching it here (consumeInput.patch).

Basically the "delaySeek" value is larger than the size of he first buffer, so
setting _consumed to the requested size is incorrect, and leaves _pos in a
wrong state.

Bastiaan, if you think the new code is worth it, I'd revert the revert and
apply this patch. I dunno if you run performance tests to check how the new
code compared to the old...

(file #35661)
    _______________________________________________________

Additional Item Attachment:

File name: consumeInput.patch             Size:0 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46607>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/