gnash-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Gnash-commit] [patch #9279] Patch to fix wrong behavior in getURL()/Mov


From: Nutchanon Wetchasit
Subject: [Gnash-commit] [patch #9279] Patch to fix wrong behavior in getURL()/MovieClip.getURL() on `undefined` and `null` target
Date: Sun, 5 Mar 2017 06:45:27 -0500 (EST)
User-agent: Opera/9.80 (Windows NT 5.1; U; en) Presto/2.10.229 Version/11.64

Follow-up Comment #1, patch #9279 (project gnash):

Patch 2 of 6:
See the attached `0002_correct-movieclip-geturl-undefined-target.patch`.

This patch makes Gnash's implementation of `MovieClip.getURL()`
<https://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/asobj/MovieClip_as.cpp?id=144e0827072b746b2bedebe39ca8a7e0fb43a455#n1089>
treat `undefined` target parameter as if it was an empty string; like Flash
Player always does, no matter of SWF version
<https://savannah.gnu.org/bugs/?50393#comment1>.

Corresponding 2 XFAILED checks in Gnash testsuite are changed to PASSED in
this patch; resulting in more 8 PASSED checks total when counted all SWF
version and test method. (4 more PASSED in automated run, and 4 more PASSED in
browser-based run)

Gnash: 0.8.11dev (patched against git 144e082 22-Feb-2017)
Adobe Flash Player: 11.2.202.491 (NPAPI binary)
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386


(file #39890)
    _______________________________________________________

Additional Item Attachment:

File name: 0002_correct-movieclip-geturl-undefined-target.patch Size:3 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9279>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]