[Gnash-commit] [bug #50462] Gnash shows weird version information when built from detached-HEAD Git repository

[Nutchanon Wetchasit]

Follow-up Comment #8, bug #50462 (project gnash):

I have re-checked the patch with on-tree and off-tree building: the problem
seems to caused by an error on my part, sorry. (It's a mix-up between Make's
and Make's sub-shell variable)

>From Makefile patched by original patch (file #39917):

            nick="`basename "$(nick)"`"; \
            if test -z "$(nick)"; then \
                  nick="none"; \
            fi; \


It should have been...

            nick="`basename "$${nick}"`"; \
            if test -z "$${nick}"; then \
                  nick="none"; \
            fi; \


As there's no Make variable named "nick", it causes branch nickname to always
be assigned as "none"; no matter that Git HEAD is currently on a valid branch
or not. On-tree V.S. off-tree building configuration is irrelevant in this
case.

I have attached the corrected patch as
`0001_use-git-symbolicref-for-revno-branch-v2.patch`.

Gnash: 0.8.11dev (patched against git 144e082 22-Feb-2017)
Git: 1:1.7.10.4-1+wheezy1 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386


(file #39935)
    _______________________________________________________

Additional Item Attachment:

File name: 0001_use-git-symbolicref-for-revno-branch-v2.patch Size:1 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?50462>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/