Re: [Gnash-dev] CommonGetUrl behaviour.

[annonygmouse]

strk wrote:
> [moved discussion to gnash-dev for broader audience, please keep it here]
>
> On Mon, Sep 18, 2006 at 12:01:38PM +0400, Vitaly Alexeev wrote:
>
> > strk <address@hidden> wrote:   The patch you applied doesn't modify code for 
> > loadMovie() but for
> > getURL. I don't think load of an external movie is what we need here
> > except (maybe) if the Method has value = 64.
> > See https://savannah.gnu.org/bugs/?17616

> > Hi,
> >  I have made it so because loadMovie("test.swf", _root) should change  current root movie on 
> > test.swf in the same window. And loadMovie("test.swf", _root.clip) should change  child movieclip 
> > "_root.clip" on test.swf.
>
>
> loadMovie should *not* be handled by the CommonGetUrl function.
> CommonGetUrl is only meant for GetUrl and GetUrl2 SWF tag handling.

Note: What I'll say is for gnash working as a plugin.
As it is now, loadMovie works for me when GetUrl2 calls a target defined 
previously (a tag). The only thing I had to modify was to give loadMovie
the ABSOLUTE URL, because using a relative URL, it searched the file 
inside the filesystem instead of grabbing the flash file from http.
As strk says, maybe this will only be the case when Method has value = 
64. But I don't know flash/gnash so much as to confirm it.

Maybe we should differenciate between "embedded" movie and "external" movie?

AFAIK there are two things that will determine where the "movie" has to 
be rendered:
        - Method number
        - Target

The documentation I found at
http://sswf.sourceforge.net/SWFalexref.html#action_get_url2
defines many of the possible target values.
It also defines possible Method values:
0       <don't send variables>
1       GET
2       POST
here we should add value "64" that means AFAIK load&render inside a 
canvas in own flash, canvas determined by target name.

In the patch I created:
https://savannah.gnu.org/file/todo_loadmovie.diff?file_id=10728
you can see I tried to take into account all the known targets, what do 
you think?

> --strk;
>
>
> >  I agree with 
> >  "
> >  I suggest we add a list of testcases URLs inside comments of that
> > CommonGetUrl function so for every change we can test them all before
> > committing."

Agreed: A testcase: http://www.garfield.com/comics/comics_todays.html
(lower_todayscomic.swf should render four flash files in its canvas).

Sebastià

                
___________________________________________________________ 
The all-new Yahoo! Mail goes wherever you go - free your email address from your Internet provider. http://uk.docs.yahoo.com/nowyoucan.html