Re: [Gnash-dev] configure.ac

[Bastiaan Jacques]

On Wed, 2007-01-24 at 18:24 +0000, Martin Guy wrote:
> Hi folks
>   I'm gonna regularise the indentation in configure.ac because it is
> such a mess in places that it tricked bastiaan into putting some
> necessary fltk tests inside an if $gui=gtk clause.

It is a moot point, but it looks like that wasn't my code. ;)

That said, I think we desperately need indentation fixes throughout the
codebase -- not just configure.ac. If you look at files like gui/sdl.cpp
and gui/gui.cpp, you see that pretty much every contributor uses his own
style. This is a problem, because it makes the code difficult to read --
and the next person looking to edit the file won't know which style to
use (and might use his own). I think we need to do two things:

1) Decide on a single coding style. Use this style for all new source
files.
2) Enforce that every patch matches the style of whatever file he is
editing, _regardless what that style may be_.

Previously, we've been talking about using automated tools to convert
existing source code to whatever new style we decide on. I wonder what
impact that will have on code that was deliberately formatted some way
for clarity...

Bastiaan