Re: [Gnash-dev] file name conflic cause compiler error

[strk]

I've committed a big files scramble for this.
server/sound.{cpp,h} was now moved to server/parser/sound_definition.{cpp,h}
AND backend/sound_handler.h.

--strk;

On Tue, Feb 27, 2007 at 08:52:22AM +0100, strk wrote:
> Welcome back Zou !
> After a quick read at sound.h I think we should split it into
> some files under server/swf/ (like StartStreamSoundTag, SoundStreamBlockTag
> etc). Additionally, the .cpp file contain a couple of global functions:
> 
>         void    set_sound_handler(sound_handler* s);
>       sound_handler*  get_sound_handler();
> 
> And the definition of the corresponding sound handler.
> 
> The base class for sound_handler is defined in server/gnash.h.
> My suggestion is to move it under backend/sound_handler.h and
> turn those global setter/getters into static function of the
> sound_handler class.
> 
> Comments ?
> 
> --strk;
>  
> 
> 
> On Tue, Feb 27, 2007 at 11:42:03AM +0800, zou lunkai wrote:
> > I got a problem while compiling HEAD Gnash today.
> > 
> > The output error  looks like this:
> > 
> > * Sound.cpp: In function 'void gnash::sound_stop(const gnash::fn_call&)':
> > * Sound.cpp:312: error: 'sound_sample_impl' was not declared in this scope
> > 
> > To check the server/asobj/Sound.cpp, I found the problem was related
> > with file names.
> > Note that there is a 'sound.h' in  gnash/server  and a 'Sound.h' in
> > gnash/server/asobj.
> > 'sound_sample_impl' is defined in ./server/sound.h, and 'Sound.cpp'
> > is dependent on both
> > the two headfiles.
> > 
> > For my file system is case insensitive, the compiler could only find
> > one headfile 'Sound.h' or 'sound.h'. Then I got the above undeclared
> > symbol problem.
> > 
> > To fix that, changing the  directive '#include sound.h' to '#include
> > ../server/sound.h'
> > works for me. But it's not clean. Is it worthwhile to change the
> > server/sound.h to another
> > name like sound_definition.h or anything else to avoid  this conflict?
> > 
> > zou lunkai
> > 2007-02-27
> 
> 
> _______________________________________________
> Gnash-dev mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/gnash-dev

-- 

 ()   ASCII Ribbon Campaign
 /\   Keep it simple!