Re[2]: [Gnash-dev] release criteria ?

[Udo Giacomozzi]

Hello strk,

Friday, May 4, 2007, 2:07:53 PM, you wrote:
s> 1)  I always see the video bounds invalidated, even whtn no new
s> video frame is available. 

Can't confirm. There is this code in video_stream_instance.cpp:

void
video_stream_instance::advance(float /*delta_time*/)
{
        if (_ns) {
                _ns->advance();
                if (_ns->newFrameReady()) set_invalidated();
        }
}

And when newFrameReady() is called the video area is not drawn:

Some debug:

video: new frame is ready.
 --> drawing Finite range (-40,-34.0303 9040.32,6797.64), Finite range 
(1354,6963 1700.47,7190.76)
 
video: new frame is ready.
 --> drawing Finite range (-40,-34.0303 9040.32,6797.64), Finite range 
(1354,6963 1703.62,7190.76)

video: NO NEW FRAME!
 --> drawing Finite range (4355.99,6859.97 5059.86,7242.48), Finite range 
(1298.08,6871 1740.82,7291.27)
(this is just the control bar area)

video: new frame is ready.
 --> drawing Finite range (-40,-34.0303 9040.32,6797.64), Finite range 
(1354,6963 1710.66,7190.76)




s> 2) We should also implement get_bounds and getBounds for proper hit test and 
AS getBounds

Agree.

s> I'll check (2), but for (1) we need to inspect the problem closely (ie: we'd 
need some
s> debugging of *when* ::display is called [ ie: might be the "still" frames I 
see are just
s> due to the fact ::display is simply not called again ]

s> --strk;



Udo