Re: [Gnash-dev] AMF::encodeElement

[Rob Savoye]

On Tue, Dec 09, 2008 at 01:32:38PM +0100, strk wrote:

> > This gives a total buffer length of 10 (7+3)
> > but Element::encode() returns a buffer of 12 bytes.
 
  I haven't seen this bug, is it reproduceable with one of the libnet.all
test cases ? It may be a bug on the encoding for the more complex objects of
which NetConnection is.

> There's also an AMF::encodeProperty, so maybe we should
> use AMF_HEADER_SIZE in AMF::encodeElement ?

  Probably.

> Most of the problems I encounter seems to be based
> on computing the encoded size of an Element object.
> Element::getDataSize only returns the size of the
> underlying Buffer, but an Element might also have
> a name, and an optional list of Element properties,
> each with its own size.
 
  This isn't a problem, it's already supported. 

> Should we define a ::getEncodedSize function to
> scan all componets and tell us ?

  It's called AMF::totalsize(). It should have been visible in the doxygen
output. :-)

        - rob -