[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnash-dev] Re: [PATCH] libamf/lcshm.cpp: fix "cast loses precision"
From: |
Melchior FRANZ |
Subject: |
Re: [Gnash-dev] Re: [PATCH] libamf/lcshm.cpp: fix "cast loses precision" error |
Date: |
Sat, 25 Jul 2009 00:34:49 +0200 |
User-agent: |
KMail/1.12.90 (Linux/2.6.30.2; KDE/4.3.61; x86_64; svn-1001938; 2009-07-24) |
* Benjamin Wolsey -- Friday 24 July 2009:
> > +++ libamf/lcshm.cpp
> > - if ( (unsigned int)Listener::getBaseAddress() == 0x0 )
> > + if ( Listener::getBaseAddress() == 0x0 )
> The fix for this, as well as being generally much better coding style,
> is:
Indeed. Just like %p is better coding style than 0x%x. But as this was
rejected yesterday, I tried it minimalistic this time. Whatever I do
seems wrong. :-P
> (If you don't state the obvious in bug reports, there is a risk that no
> action will be taken.)
Even more obvious than the literal compiler error message (which is all
*I* got), *plus* a patch?
m.