Re: gnokiid AT command reference

[Daniele Forsi]

Saturday 29 January 2005 18:07, Pawel Kot wrote:
> You can find all supported commands by reading common/data/at-emulator.c
> file. If you'd like to write such documentation it would be great :-)

I've read the source and done some testing. I hope I can submit a draft to 
this list in a couple of days.

I've found some problems and would like to know your opinion:

1) Some messages have \r\n at the beginning while most(?) have it at the end
2) Some messages have \r\n as EOL, which I think is more compatible, while 
others have \n\r
3) spaces before AT and between commands are treated as errors
4) ATQ is ignored
5) ATI1 prints IMEI from a global variable while AT+CGSN every time reads it 
from phone
6) ATI2 prints revision number from a global variable while AT+CGMR every time 
reads it from phone
7) AT#CID=2 should return ERROR (it's the patch I sent a few months ago)
8) gn_atem_command_plusc() and gn_atem_command_plusg() fail silently without 
printing ERROR for non implemented commands like AT+Cfoo

1) is the only thing that needs to be corrected to avoid things like
> at+cgmi
>
> Nokia Mobile PhonesOK
instead of
> at+cgmi
> Nokia Mobile Phones
> OK

2) changing \n\r to \r\n will break gettext() translations (I think), however 
Italian translation needs to be redone from scratch because is out of sync 
and many strings are missing, is the original translator here?

3) 4) 5) 6) 7) are low priority but easily done

8)
function gn_atem_command_plusg() is easy to fix just adding 
gn_atem_modem_result(MR_ERROR);
before return (true);

function gn_atem_command_plusc() I've done this ugly hack

bool    gn_atem_command_plusc(char **buf)
{
        if (gn_atem_command_plusc2(buf)) {
                gn_atem_modem_result(MR_ERROR);
                return (true);
        } else {
                return (false);
        }
}

There are some things that worked in 0.6.3 and fail in CVS version, namely 
at+csq and commands related to SMS, but the problem is not specific to 
gnokiid, so I'm going to start another thread.

Daniele